Haldis/haldis
2
0
Fork 0
Code Issues 39 Pull requests Packages Projects Releases Wiki Activity

Incorrect comment #13

New issue
Closed
opened 2020-01-25 21:08:22 +00:00 by midgard · 2 comments
midgard commented 2020-01-25 21:08:22 +00:00 (Migrated from git.zeus.gent)
Copy link

0af72376a1/app/views/order.py (L228-230)

explains that mypy gives a "Missing return statement" but links to an issue on the mypy bug tracker about the same error message reported after exhaustive enum matching. This is a completely different situation.

https://git.zeus.gent/midgard/haldis/blob/0af72376a10cbf71b2b6183a8afcff464cae59b9/app/views/order.py#L228-230 explains that mypy gives a "Missing return statement" but links to an issue on the mypy bug tracker about the same error message reported after exhaustive enum matching. This is a completely different situation.
midgard commented 2020-07-18 21:53:07 +00:00 (Migrated from git.zeus.gent)
Copy link

Fixed in 65fa6441b1

Fixed in 65fa6441b132c244ab796014efaa3a4d215fd43f
midgard commented 2020-07-18 21:53:07 +00:00 (Migrated from git.zeus.gent)
Copy link

closed

closed
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
slug
hlds-verify-choice-option-count
feature/invitelink-token
feature/microsoft-auth
feature/slugs
show-logo-at-home
order-no-auth
feature-126
No results found.
Labels
Clear labels   
Doing

   
To Do

   
bug

   
hlds

   
ui

   
wishlist

   
wontfix
No labels
Doing
To Do
bug
hlds
ui
wishlist
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Haldis/haldis#13
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?