Tag definition #28
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Tags should be defined so they can be shown to the user.
One should also be able to make them either combining (tags for the combination of two items are ORred) or intersecting (AND).{has_meat} taking union: Bevat vlees
{vegetarian} taking intersection: Vegetarisch
After discussion with @j it seems always taking AND makes more sense.
changed milestone to %1
removed milestone
changed the description
changed the description
Would need a way to make tags combine (if you select a
vegetarian
option on avegan
dish, it should becomevegetarian
).I might have mentioned it before, but dishes should have a list of things they contain (
contains_meat
,contains_animal_product
), here union should be taken over all tags. At the end, these can then get translated to human-readable descriptions (so ifcontains_meat
is not present, vegetarian). This also allows for adding more similar things like gluten.That has the drawback that people adding dishes need to be aware of what's contained. A "suitable for vegetarians" or "gluten-free" label is fail-safe in that regard.
But on the other hand it might be more elegant and straightforward to tag the "problematic" items. Maybe a solution for the "someone forgot to tag the meat" would be to mark both the presence and absence of meat (and show in the UI that the veggie status of the dish is unknown). Or do good review on the merge requests.