Tag definition #28

Open
opened 2020-01-27 01:00:41 +01:00 by midgard · 8 comments
midgard commented 2020-01-27 01:00:41 +01:00 (Migrated from git.zeus.gent)

Tags should be defined so they can be shown to the user.

One should also be able to make them either combining (tags for the combination of two items are ORred) or intersecting (AND).

{has_meat} taking union: Bevat vlees
{vegetarian} taking intersection: Vegetarisch

After discussion with @j it seems always taking AND makes more sense.

Tags should be defined so they can be shown to the user. ~~One should also be able to make them either combining (tags for the combination of two items are ORred) or intersecting (AND).~~ ~~`{has_meat} taking union: Bevat vlees`~~ ~~`{vegetarian} taking intersection: Vegetarisch`~~ After discussion with @j it seems always taking AND makes more sense.
midgard commented 2020-01-27 01:00:41 +01:00 (Migrated from git.zeus.gent)

changed milestone to %1

changed milestone to %1
midgard commented 2020-03-04 17:54:51 +01:00 (Migrated from git.zeus.gent)

removed milestone

removed milestone
midgard commented 2020-07-27 01:17:09 +02:00 (Migrated from git.zeus.gent)

changed the description

changed the description
midgard commented 2020-08-19 11:40:22 +02:00 (Migrated from git.zeus.gent)

changed the description

changed the description
midgard commented 2021-06-17 23:48:39 +02:00 (Migrated from git.zeus.gent)

Would need a way to make tags combine (if you select a vegetarian option on a vegan dish, it should become vegetarian).

Would need a way to make tags combine (if you select a `vegetarian` option on a `vegan` dish, it should become `vegetarian`).
j commented 2021-06-17 23:54:54 +02:00 (Migrated from git.zeus.gent)

I might have mentioned it before, but dishes should have a list of things they contain (contains_meat, contains_animal_product), here union should be taken over all tags. At the end, these can then get translated to human-readable descriptions (so if contains_meat is not present, vegetarian). This also allows for adding more similar things like gluten.

I might have mentioned it before, but dishes should have a list of things they contain (`contains_meat`, `contains_animal_product`), here union should be taken over all tags. At the end, these can then get translated to human-readable descriptions (so if `contains_meat` is not present, vegetarian). This also allows for adding more similar things like gluten.
midgard commented 2021-06-17 23:57:34 +02:00 (Migrated from git.zeus.gent)

That has the drawback that people adding dishes need to be aware of what's contained. A "suitable for vegetarians" or "gluten-free" label is fail-safe in that regard.

That has the drawback that people adding dishes need to be aware of what's contained. A "suitable for vegetarians" or "gluten-free" label is fail-safe in that regard.
midgard commented 2021-06-21 02:13:16 +02:00 (Migrated from git.zeus.gent)

But on the other hand it might be more elegant and straightforward to tag the "problematic" items. Maybe a solution for the "someone forgot to tag the meat" would be to mark both the presence and absence of meat (and show in the UI that the veggie status of the dish is unknown). Or do good review on the merge requests.

But on the other hand it might be more elegant and straightforward to tag the "problematic" items. Maybe a solution for the "someone forgot to tag the meat" would be to mark both the presence and absence of meat (and show in the UI that the veggie status of the dish is unknown). Or do good review on the merge requests.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Haldis/haldis#28
No description provided.