Kelder/obus
33
0
Fork 0
Code Issues 3 Pull requests Projects Releases Packages Wiki Activity

Add more robust error printing

Browse source
This commit is contained in:
redfast00 2022-03-15 13:46:18 +01:00
parent b048e11b04
commit 4d54cd4285
No known key found for this signature in database
GPG key ID: 5946E0E34FD0553C
3 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/obus_can.cpp
View file

@ -190,6 +190,10 @@ bool is_error_condition() {
return mcp2515.getInterrupts() & MCP2515::CANINTF_ERRIF; return mcp2515.getInterrupts() & MCP2515::CANINTF_ERRIF;
} }
uint8_t get_error_flags() {
return mcp2515.getErrorFlags();
}
void send(struct message *msg) { void send(struct message *msg) {
if (!is_init) { if (!is_init) {
Serial.println(F("E Call init first")); Serial.println(F("E Call init first"));

1
lib/obus_can.h
View file

@ -113,6 +113,7 @@ void send(struct message *msg);
bool is_error_condition(); bool is_error_condition();
uint8_t get_error_flags();
/** /**
* For internal use only * For internal use only

8
lib/obus_module.cpp
View file

@ -6,6 +6,7 @@
#define BLINK_DELAY_SLOW 1000 #define BLINK_DELAY_SLOW 1000
#define BLINK_DELAY_FAST 300 #define BLINK_DELAY_FAST 300
#define BLINK_DELAY_VERY_FAST 100
#define MAX_TIME_BETWEEN_CALLS 100 #define MAX_TIME_BETWEEN_CALLS 100
@ -79,11 +80,11 @@ void _setLedBlink(struct color color, uint16_t delay) {
void blink_error(String message) { void blink_error(String message) {
bool blink = false; bool blink = false;
digitalWrite(PIN_LED_GREEN, LOW);
while (true) { while (true) {
digitalWrite(PIN_LED_RED, blink); digitalWrite(PIN_LED_RED, blink);
digitalWrite(PIN_LED_GREEN, blink);
blink = !blink; blink = !blink;
delay(blink ? BLINK_DELAY_SLOW : BLINK_DELAY_FAST); delay(BLINK_DELAY_VERY_FAST);
Serial.println(message); Serial.println(message);
} }
} }
@ -132,7 +133,8 @@ bool loopPuzzle(obus_can::message* message, void (*callback_game_start)(uint8_t
// We will need to fork our CAN library for this, because the needed functions are private. // We will need to fork our CAN library for this, because the needed functions are private.
// Also, we can't do this by default, because the INT pin is normally not connected to the board // Also, we can't do this by default, because the INT pin is normally not connected to the board
if (obus_can::is_error_condition()) { if (obus_can::is_error_condition()) {
blink_error(F("E CAN error"));
blink_error("E CAN error " + String(obus_can::get_error_flags(), BIN));
} }
// Force the user of the library to periodically call loop // Force the user of the library to periodically call loop