From 141e25ee38906d187f284452a349589bd69bfb2c Mon Sep 17 00:00:00 2001
From: maartenvn <maartenvn.eu@gmail.com>
Date: Mon, 27 Jul 2020 17:56:09 +0200
Subject: [PATCH] Use regular buttons instead of inputs for better
 accessibility

---
 events/templates/events/registrations.html |  6 ++++--
 static/main.css                            | 20 +++++++++++++-------
 users/templates/users/profile.html         |  2 +-
 3 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/events/templates/events/registrations.html b/events/templates/events/registrations.html
index b2ac596..6b2f599 100644
--- a/events/templates/events/registrations.html
+++ b/events/templates/events/registrations.html
@@ -14,8 +14,10 @@
 	{% elif not user.has_ugent_info %}
 		<p class="text--important">Je moet je studentennummer en echte naam invullen in je profiel voor je je kan inschrijven.</p>
 	{% elif not my_registration %}
-	<p><input type="submit" value="Ik wil komen"></p>
+		<button type="submit">Ik wil komen</button>
 	{% else %}
-	<p>Mijn status: {{ my_registration.state_str }} <input type="submit" value="Uitschrijven"></input></p>
+		<p>Mijn status: {{ my_registration.state_str }}</p>
+		
+		<button type="submit">Uitschrijven</button>
 	{% endif %}
 </form>
diff --git a/static/main.css b/static/main.css
index 15736f8..6f66815 100644
--- a/static/main.css
+++ b/static/main.css
@@ -5,7 +5,7 @@ body {
 	font-family: monospace;
 }
 
-input, textarea {
+input, textarea, button {
 	font-family: inherit;
 	font-size: inherit;
 }
@@ -78,6 +78,10 @@ h1 a:hover, h1 a:focus, h1 a:active {
 	background-color: rgba(255, 255, 255, 0.1);
 }
 
+.text--important {
+	color: #e74c3c;
+}
+
 /*change the layout of the navigation bar for all the screens
 that have a width less or equal than 500px*/
 
@@ -175,24 +179,26 @@ textarea {
 select:focus,
 input:focus,
 textarea:focus,
-button:focus {
+button:active {
 	background: hsl(0, 0%, 20%);
 }
 
 select:focus,
 input:focus,
-textarea:focus {
+textarea:focus
+button:active {
 	transform: scale(1.02);
 }
 
+/* Hover styling */
+button:hover:not([disabled]) {
+	cursor: pointer;
+}
+
 footer {
 	color: #777777;
 	padding: 10px;
 }
 footer a {
 	color: #888888;
-}
-
-.text--important {
-	color: #e74c3c;
 }
\ No newline at end of file
diff --git a/users/templates/users/profile.html b/users/templates/users/profile.html
index ce108ce..fced0b7 100644
--- a/users/templates/users/profile.html
+++ b/users/templates/users/profile.html
@@ -10,7 +10,7 @@
 		<form action="/user/profile" method="post">
 			{% csrf_token %}
 			{{ form }}
-			<input type="submit" value="Bijwerken">
+			<button type="submit">Bijwerken</button>
 		</form>
 	{% else %}
 		<p>Niet ingelogd</p>