From 93a81b77fa63cfbf35fbac6df6b1d8ec1a1f8dcd Mon Sep 17 00:00:00 2001
From: Pieter Vander Vennet <pietervdvn@posteo.net>
Date: Wed, 24 Jan 2024 16:35:34 +0100
Subject: [PATCH 1/3] Fix undefined crash

---
 src/UI/Popup/TagRendering/TagRenderingQuestion.svelte | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/UI/Popup/TagRendering/TagRenderingQuestion.svelte b/src/UI/Popup/TagRendering/TagRenderingQuestion.svelte
index b67c17b45..f45f6062c 100644
--- a/src/UI/Popup/TagRendering/TagRenderingQuestion.svelte
+++ b/src/UI/Popup/TagRendering/TagRenderingQuestion.svelte
@@ -396,7 +396,7 @@
             <!-- TagRenderingQuestion-buttons -->
             <slot name="cancel" />
             <slot name="save-button" {selectedTags}>
-              {#if allowDeleteOfFreeform && mappings.length === 0 && $freeformInput === undefined && $freeformInputUnvalidated === ""}
+              {#if allowDeleteOfFreeform && mappings?.length === 0 && $freeformInput === undefined && $freeformInputUnvalidated === ""}
                 <button class="primary flex" on:click|stopPropagation|preventDefault={_ => onSave(_, true)}>
                   <TrashIcon class="w-6 h-6 text-red-500" />
                   <Tr t={Translations.t.general.eraseValue}/>

From 0bfc8d6dc4d8f88de3d2cf0038a946837033a3e7 Mon Sep 17 00:00:00 2001
From: Pieter Vander Vennet <pietervdvn@posteo.net>
Date: Wed, 24 Jan 2024 16:36:07 +0100
Subject: [PATCH 2/3] Fix undefined crash

---
 src/UI/Popup/TagRendering/TagRenderingQuestion.svelte | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/UI/Popup/TagRendering/TagRenderingQuestion.svelte b/src/UI/Popup/TagRendering/TagRenderingQuestion.svelte
index f45f6062c..cf4bd3117 100644
--- a/src/UI/Popup/TagRendering/TagRenderingQuestion.svelte
+++ b/src/UI/Popup/TagRendering/TagRenderingQuestion.svelte
@@ -54,7 +54,7 @@
    */
   let checkedMappings: boolean[]
 
-  let mappings: Mapping[] = config?.mappings
+  let mappings: Mapping[] = config?.mappings ?? []
   let searchTerm: UIEventSource<string> = new UIEventSource("")
 
   let dispatch = createEventDispatcher<{

From fb855b450ebf6f373c981367287f37b0e351d2e5 Mon Sep 17 00:00:00 2001
From: Pieter Vander Vennet <pietervdvn@posteo.net>
Date: Wed, 24 Jan 2024 16:40:55 +0100
Subject: [PATCH 3/3] Remove debug output

---
 src/UI/Popup/TagRendering/TagRenderingQuestion.svelte | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/UI/Popup/TagRendering/TagRenderingQuestion.svelte b/src/UI/Popup/TagRendering/TagRenderingQuestion.svelte
index cf4bd3117..fbcc2d3a0 100644
--- a/src/UI/Popup/TagRendering/TagRenderingQuestion.svelte
+++ b/src/UI/Popup/TagRendering/TagRenderingQuestion.svelte
@@ -153,7 +153,7 @@
     }
   })
   $: {
-    if (allowDeleteOfFreeform && $freeformInput === undefined && $freeformInputUnvalidated === "" && mappings.length === 0) {
+    if (allowDeleteOfFreeform && $freeformInput === undefined && $freeformInputUnvalidated === "" && mappings?.length === 0) {
       selectedTags = new Tag(config.freeform.key, "")
     } else {
 
@@ -172,8 +172,6 @@
   }
 
   function onSave(e = undefined, deleteFreeform = false) {
-    console.log("On click", deleteFreeform, ">>>", selectedTags)
-
     if (selectedTags === undefined) {
       return
     }