midgard/mapcomplete
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Some work on stabilizing the popups, WIP

Browse source
This commit is contained in:
pietervdvn 2021-02-05 18:58:06 +01:00
parent 8f8ef690a4
commit 1f4b06ae55
5 changed files with 55 additions and 44 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Logic/Actors/SelectedFeatureHandler.ts
View file

@ -40,6 +40,10 @@ export default class SelectedFeatureHandler {
if(features === undefined){
return;
}
if(this._selectedFeature.data?.properties?.id === this._hash.data){
// Feature already selected
return;
}
for (const feature of features) {
const id = feature.feature?.properties?.id;
if(id === this._hash.data){

13
UI/Base/LazyElement.ts
View file

@ -1,24 +1,21 @@
import {UIElement} from "../UIElement";
export default class LazyElement<T extends UIElement> extends UIElement {
export default class LazyElement extends UIElement {
public Activate: (onElement?: (element: T) => void) => void;
private _content: T = undefined;
public Activate: () => void;
private _content: UIElement = undefined;
private readonly _loadingContent: string;
constructor(content: (() => T), loadingContent = "Rendering...") {
constructor(content: (() => UIElement), loadingContent = "Rendering...") {
super();
this._loadingContent = loadingContent;
this.dumbMode = false;
const self = this;
this.Activate = (onElement?: (element: T) => void) => {
this.Activate = () => {
if (this._content === undefined) {
self._content = content();
}
if (onElement) {
onElement(self._content)
}
self.Update();
}
}

17
UI/Popup/FeatureInfoBox.ts
View file

@ -12,7 +12,7 @@ import ScrollableFullScreen from "../Base/ScrollableFullScreen";
export default class FeatureInfoBox extends UIElement {
private _component: ScrollableFullScreen;
constructor(
private constructor(
tags: UIEventSource<any>,
layerConfig: LayerConfig,
onClose: () => void
@ -77,4 +77,19 @@ export default class FeatureInfoBox extends UIElement {
private static featureInfoboxCache : Map<LayerConfig, Map<UIEventSource<any>, FeatureInfoBox>> = new Map<LayerConfig, Map<UIEventSource<any>, FeatureInfoBox>>();
static construct(tags: UIEventSource<any>, layer: LayerConfig, onClose: () => void) {
let innerMap = FeatureInfoBox.featureInfoboxCache.get(layer);
if(innerMap === undefined){
innerMap = new Map<UIEventSource<any>, FeatureInfoBox>();
FeatureInfoBox.featureInfoboxCache.set(layer, innerMap);
}
let featureInfoBox = innerMap.get(tags);
if(featureInfoBox === undefined){
featureInfoBox = new FeatureInfoBox(tags, layer, onClose);
innerMap.set(tags, featureInfoBox);
}
return featureInfoBox;
}
}

2
UI/Popup/TagRenderingQuestion.ts
View file

@ -43,7 +43,7 @@ export default class TagRenderingQuestion extends UIElement {
this._tags = tags;
this._configuration = configuration;
this._cancelButton = cancelButton;
this._question = new SubstitutedTranslation(this._configuration.question, tags)
this._question = SubstitutedTranslation.construct(this._configuration.question, tags)
.SetClass("question-text");
if (configuration === undefined) {
throw "A question is needed for a question visualization"

57
UI/ShowDataLayer.ts
View file

@ -7,12 +7,8 @@ import "leaflet.markercluster"
import LayerConfig from "../Customizations/JSON/LayerConfig";
import State from "../State";
import LazyElement from "./Base/LazyElement";
import Hash from "../Logic/Web/Hash";
import {GeoOperations} from "../Logic/GeoOperations";
import FeatureInfoBox from "./Popup/FeatureInfoBox";
import LayoutConfig from "../Customizations/JSON/LayoutConfig";
import {UIElement} from "./UIElement";
import Combine from "./Base/Combine";
import ScrollableFullScreen from "./Base/ScrollableFullScreen";
@ -34,6 +30,18 @@ export default class ShowDataLayer {
this._layerDict[layer.id] = layer;
}
function openSelectedElementFeature(feature: any){
if (feature === undefined) {
return;
}
const id = feature.properties.id + feature.geometry.type + feature._matching_layer_id;
const action = self._onSelectedTrigger[id];
if (action) {
action();
}
}
function update() {
if (features.data === undefined) {
return;
@ -60,21 +68,10 @@ export default class ShowDataLayer {
oldGeoLayer = geoLayer;
}
features.addCallbackAndRun(() => update());
features.addCallback(() => update());
leafletMap.addCallback(() => update());
State.state.selectedElement.addCallback(feature => {
if (feature === undefined) {
return;
}
const id = feature.properties.id + feature.geometry.type + feature._matching_layer_id;
const action = self._onSelectedTrigger[id];
if (action) {
action();
}
});
update();
State.state.selectedElement.addCallbackAndRun(openSelectedElementFeature);
}
@ -121,12 +118,14 @@ export default class ShowDataLayer {
const tags = State.state.allElements.getEventSourceFor(feature);
const uiElement: LazyElement<UIElement> = new LazyElement(() =>new Combine([ new FeatureInfoBox(tags, layer, () => {
const uiElement = new LazyElement(() =>
FeatureInfoBox.construct(tags, layer, () => {
State.state.selectedElement.setData(undefined);
popup.remove();
})]),
"<div style='height: 90vh'>Rendering</div>");
leafletLayer.closePopup();
ScrollableFullScreen.RestoreLeaflet();
}),
"<div style='height: 90vh'>Rendering</div>"); // By setting 90vh, leaflet will attempt to fit the entire screen and move the feature down
popup.setContent(uiElement.Render());
popup.on('remove', () => {
ScrollableFullScreen.RestoreLeaflet(); // Just in case...
@ -139,25 +138,21 @@ export default class ShowDataLayer {
// We first render the UIelement (which'll still need an update later on...)
// But at least it'll be visible already
leafletLayer.on("click", () => {
// We set the element as selected...
leafletLayer.on("popupopen", () => {
uiElement.Activate();
State.state.selectedElement.setData(feature);
});
})
const id = feature.properties.id + feature.geometry.type + feature._matching_layer_id;
this._onSelectedTrigger[id]
= () => {
if (popup.isOpen()) {
return;
}
if (!popup.isOpen()) {
leafletLayer.openPopup();
uiElement.Activate();
State.state.selectedElement.setData(feature);
return;
}
}
this._onSelectedTrigger[feature.properties.id.replace("/", "_")] = this._onSelectedTrigger[id];
}
private CreateGeojsonLayer(features: any[]): L.Layer {