Add check for duplicate ids in layers, fix duplicates

Models/ThemeConfig/Conversion/Validation.ts

@@ -455,6 +455,15 @@ export class ValidateLayer extends DesugaringStep<LayerConfigJson> {
             }
         }
 
+        {
+            // duplicate ids in tagrenderings check
+          const duplicates = Utils.Dedup(Utils.Dupiclates( Utils.NoNull((json.tagRenderings ?? []).map(tr => tr["id"]))))
+              .filter(dupl => dupl !== "questions")
+            if(duplicates.length > 0){
+                errors.push("At "+context+": some tagrenderings have a duplicate id: "+duplicates.join(", "))
+            }
+        }
+        
         try {
             {
                 // Some checks for legacy elements
@@ -472,7 +481,7 @@ export class ValidateLayer extends DesugaringStep<LayerConfigJson> {
                 }
             }
             {
-                // CHeck location of layer file
+                // Check location of layer file
                 const expected: string = `assets/layers/${json.id}/${json.id}.json`
                 if (this._path != undefined && this._path.indexOf(expected) < 0) {
                     errors.push("Layer is in an incorrect place. The path is " + this._path + ", but expected " + expected)

assets/themes/mapcomplete-changes/mapcomplete-changes.proto.json

@@ -149,7 +149,7 @@
             "render": "{histogram(_embedded_cs:themes, Themename, Number of changesets)}"
           },
           {
-            "id": "hist_themes",
+            "id": "hist_users",
             "render": "{histogram(_embedded_cs:users, Contributor, Number of changesets)}"
           }
         ],