midgard/mapcomplete
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Refactoring: improve codeQuality.spec.ts to use promises

Browse source
This commit is contained in:
Pieter Vander Vennet 2023-05-16 01:34:57 +02:00
parent 82a860cbf5
commit 6f3285fbd7
1 changed files with 18 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
test/CodeQuality.spec.ts
View file

@ -7,8 +7,8 @@ import { describe, it } from "vitest"
* @param reason
* @private
*/
function detectInCode(forbidden: string, reason: string): (done: () => void) => void {
return (done: () => void) => {
function detectInCode(forbidden: string, reason: string): Promise<void> {
return new Promise<void>((done) => {
const excludedDirs = [
".git",
"node_modules",
@ -49,14 +49,23 @@ function detectInCode(forbidden: string, reason: string): (done: () => void) =>
console.error(found.length, "issues found")
throw msg
}
done()
}
)
})
}
function wrap(promise: Promise<void>): ((done: () => void) => void) {
return (done => {
promise.then(done)
})
}
function itAsync(name: string, promise: Promise<void>){
it(name, wrap(promise))
}
describe("Code quality", () => {
it(
itAsync(
"should not contain reverse",
detectInCode(
"reverse()",
@ -64,12 +73,12 @@ describe("Code quality", () => {
)
)
it(
itAsync(
"should not contain 'constructor.name'",
detectInCode("constructor\\.name", "This is not allowed, as minification does erase names.")
)
it(
itAsync(
"should not contain 'innerText'",
detectInCode(
"innerText",
@ -77,7 +86,7 @@ describe("Code quality", () => {
)
)
it(
itAsync(
"should not contain 'import * as name from \"xyz.json\"'",
detectInCode(
'import \\* as [a-zA-Z0-9_]\\+ from \\"[.-_/a-zA-Z0-9]\\+\\.json\\"',
@ -85,7 +94,7 @@ describe("Code quality", () => {
)
)
it(
itAsync(
"should not contain '[\"default\"]'",
detectInCode('\\[\\"default\\"\\]', "Possible leftover of faulty default import")
)