From 7072f2d93d55439b2c85305c8532f52d96e970e6 Mon Sep 17 00:00:00 2001
From: Pieter Vander Vennet <pietervdvn@posteo.net>
Date: Mon, 6 May 2024 11:24:26 +0200
Subject: [PATCH] UX: fix #1932

---
 src/UI/Studio/Region.svelte            |  6 +++---
 src/UI/Studio/TagRenderingInput.svelte | 19 +++++++++++--------
 2 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/src/UI/Studio/Region.svelte b/src/UI/Studio/Region.svelte
index 879d4b6ca..d572773f3 100644
--- a/src/UI/Studio/Region.svelte
+++ b/src/UI/Studio/Region.svelte
@@ -11,7 +11,7 @@
   export let configs: ConfigMeta[]
   export let title: string | undefined = undefined
 
-  export let path: (string | number)[] = []
+  export let path: readonly (string | number)[] = []
 
   let expertMode = state.expertMode
   let configsNoHidden = configs.filter((schema) => schema.hints?.group !== "hidden")
@@ -21,9 +21,9 @@
 </script>
 
 {#if configs === undefined}
-  Bug: 'Region' received 'undefined'
+  Bug: 'Region' received 'undefined' at {path.join(".")}
 {:else if configs.length === 0}
-  Bug: Region received empty list as configuration
+  Bug: Region received empty list as configuration at {path.join(".")}
 {:else if title}
   <div class="flex w-full flex-col">
     <h3>{title}</h3>
diff --git a/src/UI/Studio/TagRenderingInput.svelte b/src/UI/Studio/TagRenderingInput.svelte
index a15065ac9..cfa056435 100644
--- a/src/UI/Studio/TagRenderingInput.svelte
+++ b/src/UI/Studio/TagRenderingInput.svelte
@@ -7,7 +7,7 @@
   import type { ConfigMeta } from "./configMeta"
   import type {
     MappingConfigJson,
-    QuestionableTagRenderingConfigJson,
+    QuestionableTagRenderingConfigJson
   } from "../../Models/ThemeConfig/Json/QuestionableTagRenderingConfigJson"
   import TagRenderingConfig from "../../Models/ThemeConfig/TagRenderingConfig"
   import TagRenderingEditable from "../Popup/TagRendering/TagRenderingEditable.svelte"
@@ -59,8 +59,8 @@
           labelMapping = {
             if: "value=" + label,
             then: {
-              en: "Builtin collection <b>" + label + "</b>:",
-            },
+              en: "Builtin collection <b>" + label + "</b>:"
+            }
           }
           perLabel[label] = labelMapping
           mappingsBuiltin.push(labelMapping)
@@ -72,14 +72,14 @@
     mappingsBuiltin.push({
       if: "value=" + tr["id"],
       then: {
-        en: "Builtin <b>" + tr["id"] + "</b> <div class='subtle'>" + description + "</div>",
-      },
+        en: "Builtin <b>" + tr["id"] + "</b> <div class='subtle'>" + description + "</div>"
+      }
     })
   }
 
   const configBuiltin = new TagRenderingConfig(<QuestionableTagRenderingConfigJson>{
     question: "Which builtin element should be shown?",
-    mappings: mappingsBuiltin,
+    mappings: mappingsBuiltin
   })
 
   const tags = new UIEventSource({ value })
@@ -112,7 +112,7 @@
     "condition",
     "metacondition",
     "mappings",
-    "icon",
+    "icon"
   ])
   const ignored = new Set(["labels", "description", "classes"])
 
@@ -196,7 +196,10 @@
     <h3>Text field and input element configuration</h3>
     <div class="border-l border-dashed border-gray-800 pl-2">
       <SchemaBasedField {state} path={[...path, "render"]} schema={topLevelItems["render"]} />
-      <Region {state} {path} configs={freeformSchema} />
+      {#if freeformSchema?.length > 0}
+        <!-- In read-only cases, (e.g. popup title) there will be no freeform-schema to set and thus freeformSchema will be undefined -->
+        <Region {state} {path} configs={freeformSchema} />
+      {/if}
       <SchemaBasedField {state} path={[...path, "icon"]} schema={topLevelItems["icon"]} />
     </div>