From 8c610d0c11b5ee077243e22324e94e74c905f5bf Mon Sep 17 00:00:00 2001 From: Pieter Vander Vennet Date: Fri, 9 Oct 2020 20:28:48 +0200 Subject: [PATCH 1/3] Remove console.log --- UI/OhVisualization.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/UI/OhVisualization.ts b/UI/OhVisualization.ts index d5ce35f..cf1df28 100644 --- a/UI/OhVisualization.ts +++ b/UI/OhVisualization.ts @@ -160,7 +160,6 @@ export default class OpeningHoursVisualization extends UIElement { // ranges[0] are all ranges for monday const ranges = OpeningHoursVisualization.GetRanges(oh, lastMonday, nextSunday); - console.log(ranges) if (ranges.map(r => r.length).reduce((a, b) => a + b, 0) == 0) { // Closed! const opensAtDate = oh.getNextChange(); From 62785aa4c42dfbdbfa7601b84d6c79ef6fcb2302 Mon Sep 17 00:00:00 2001 From: Pieter Vander Vennet Date: Fri, 9 Oct 2020 20:41:26 +0200 Subject: [PATCH 2/3] Fix translations, add opening hours to cycle themed objects --- UI/i18n/Translations.ts | 4 ++-- .../cycling_themed_object/cycling_themed_objects.json | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/UI/i18n/Translations.ts b/UI/i18n/Translations.ts index fed6ab3..db386ae 100644 --- a/UI/i18n/Translations.ts +++ b/UI/i18n/Translations.ts @@ -907,8 +907,8 @@ export default class Translations { "nl": "Gesloten" }), ph_not_known: new T({ - "en": "unknown", - "nl": "niet gekend" + "en": " ", + "nl": " " }), ph_closed: new T({ "en": "closed", diff --git a/assets/layers/cycling_themed_object/cycling_themed_objects.json b/assets/layers/cycling_themed_object/cycling_themed_objects.json index 5acca30..e53ae02 100644 --- a/assets/layers/cycling_themed_object/cycling_themed_objects.json +++ b/assets/layers/cycling_themed_object/cycling_themed_objects.json @@ -47,6 +47,12 @@ "freeform": { "key": "email" } + }, + { + "render": "{opening_hours_table(opening_hours)}", + "freeform": { + "key": "opening_hours" + } } ], "hideUnderlayingFeaturesMinPercentage": 0, From 499666a88e1c2e1ac7d3a4374849babccd0f3e9f Mon Sep 17 00:00:00 2001 From: Pieter Vander Vennet Date: Fri, 9 Oct 2020 21:11:52 +0200 Subject: [PATCH 3/3] Fix dissappearing unparsed rules --- UI/Input/OpeningHours/OpeningHoursInput.ts | 10 +++++++--- test.ts | 18 +++++++++--------- 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/UI/Input/OpeningHours/OpeningHoursInput.ts b/UI/Input/OpeningHours/OpeningHoursInput.ts index 254331e..dd83dc3 100644 --- a/UI/Input/OpeningHours/OpeningHoursInput.ts +++ b/UI/Input/OpeningHours/OpeningHoursInput.ts @@ -27,9 +27,9 @@ export default class OpeningHoursInput extends InputElement { constructor(value: UIEventSource = new UIEventSource("")) { super(); - const rulesFromOhPicker = value.map(OH.Parse); - + const leftoverRules = value.map(str => { + console.log("Leftovers?",str) if (str === undefined) { return [] } @@ -46,8 +46,11 @@ export default class OpeningHoursInput extends InputElement { } return leftOvers; }) + // NOte: MUST be bound AFTER the leftover rules! + const rulesFromOhPicker = value.map(OH.Parse); const ph = value.map(str => { + console.log("PH RULE?", ph) if (str === undefined) { return "" } @@ -62,6 +65,7 @@ export default class OpeningHoursInput extends InputElement { this._phSelector = new PublicHolidayInput(ph); function update() { + console.log("UPdating") let rules = OH.ToString(rulesFromOhPicker.data); if (leftoverRules.data.length != 0) { rules += ";" + leftoverRules.data.join(";") @@ -83,7 +87,7 @@ export default class OpeningHoursInput extends InputElement { } return new Combine([ Translations.t.general.opening_hours.not_all_rules_parsed, - new FixedUiElement(leftovers.map(r => `${r}
`).join("") ).SetClass("subtle") + new FixedUiElement(leftovers.map(r => `${r}
`).join("")).SetClass("subtle") ]).Render(); })) diff --git a/test.ts b/test.ts index 761a7a4..5cfbd67 100644 --- a/test.ts +++ b/test.ts @@ -1,15 +1,15 @@ //* -import OpeningHoursVisualization from "./UI/OhVisualization"; -import {UIEventSource} from "./Logic/UIEventSource"; -new OpeningHoursVisualization( new UIEventSource({ - opening_hours: "2000 Dec 21 10:00-12:00;", - _country: "be", - _lat: "51.2", - _lon: "3.2" - } -), 'opening_hours').AttachTo("maindiv") +import {UIEventSource} from "./Logic/UIEventSource"; +import OpeningHoursInput from "./UI/Input/OpeningHours/OpeningHoursInput"; + +const oh = "Sep 1-Feb 28 Mo-Th 08:00-12:00, 13:30-17:30; Mar 1-Aug 31 Mo-Fr 07:00-12:00, 13:30-17:30; PH off" + +const source = new UIEventSource("") +new OpeningHoursInput(source).AttachTo('maindiv') +console.log("SEtting ",oh) +source.setData(oh) /*/