UX: improve attribution display, add magnifying class

langs/en.json

@@ -193,6 +193,7 @@
             },
             "josmNotOpened": "JOSM could not be reached. Make sure it is opened and remote control is enabled",
             "josmOpened": "JOSM is opened",
+            "madeBy": "Mady by <b>{author}</b>",
             "mapContributionsBy": "The current visible data has edits made by {contributors}",
             "mapContributionsByAndHidden": "The current visible data has edits made by {contributors} and {hiddenCount} more contributors",
             "mapDataByOsm": "Map data: OpenStreetMap",

public/css/index-tailwind-output.css

@@ -2073,6 +2073,12 @@ video {
   margin-bottom: calc(0px * var(--tw-space-y-reverse));
 }
 
+.space-x-4 > :not([hidden]) ~ :not([hidden]) {
+  --tw-space-x-reverse: 0;
+  margin-right: calc(1rem * var(--tw-space-x-reverse));
+  margin-left: calc(1rem * calc(1 - var(--tw-space-x-reverse)));
+}
+
 .space-x-2 > :not([hidden]) ~ :not([hidden]) {
   --tw-space-x-reverse: 0;
   margin-right: calc(0.5rem * var(--tw-space-x-reverse));
@@ -2097,12 +2103,6 @@ video {
   margin-left: calc(-1px * calc(1 - var(--tw-space-x-reverse)));
 }
 
-.space-x-4 > :not([hidden]) ~ :not([hidden]) {
-  --tw-space-x-reverse: 0;
-  margin-right: calc(1rem * var(--tw-space-x-reverse));
-  margin-left: calc(1rem * calc(1 - var(--tw-space-x-reverse)));
-}
-
 .space-y-1 > :not([hidden]) ~ :not([hidden]) {
   --tw-space-y-reverse: 0;
   margin-top: calc(0.25rem * calc(1 - var(--tw-space-y-reverse)));
@@ -2431,6 +2431,10 @@ video {
   border-top-right-radius: 0.25rem;
 }
 
+.rounded-bl-full {
+  border-bottom-left-radius: 9999px;
+}
+
 .rounded-tl {
   border-top-left-radius: 0.25rem;
 }
@@ -3454,6 +3458,14 @@ video {
   padding-top: 0px;
 }
 
+.pl-3 {
+  padding-left: 0.75rem;
+}
+
+.pb-3 {
+  padding-bottom: 0.75rem;
+}
+
 .pl-4 {
   padding-left: 1rem;
 }
@@ -3462,14 +3474,6 @@ video {
   padding-right: 1rem;
 }
 
-.pl-3 {
-  padding-left: 0.75rem;
-}
-
-.pr-3 {
-  padding-right: 0.75rem;
-}
-
 .pl-1 {
   padding-left: 0.25rem;
 }

src/UI/Image/AttributedImage.svelte

@@ -6,6 +6,7 @@
   import type { ProvidedImage } from "../../Logic/ImageProviders/ImageProvider"
   import { Mapillary } from "../../Logic/ImageProviders/Mapillary"
   import { UIEventSource } from "../../Logic/UIEventSource"
+  import { MagnifyingGlassPlusIcon } from "@babeard/svelte-heroicons/outline"
 
   export let image: Partial<ProvidedImage>
   let fallbackImage: string = undefined
@@ -16,13 +17,16 @@
   let imgEl: HTMLImageElement
   export let imgClass: string = undefined
   export let previewedImage: UIEventSource<ProvidedImage> = undefined
+  export let attributionFormat: "minimal" | "medium" | "large" = "medium"
+  let canZoom = previewedImage !== undefined // We check if there is a SOURCE, not if there is data in it!
 </script>
 
 <div class="relative shrink-0">
+  <div class="relative w-fit">
     <img
       bind:this={imgEl}
       class={imgClass ?? ""}
-    class:cursor-pointer={previewedImage !== undefined}
+      class:cursor-zoom-in={previewedImage !== undefined}
       on:click={() => {
       previewedImage?.setData(image)
     }}
@@ -34,7 +38,14 @@
       src={image.url}
     />
 
+    {#if canZoom}
+      <div class="absolute right-0 top-0 bg-black-transparent rounded-bl-full">
+      <MagnifyingGlassPlusIcon class="w-8 h-8 pl-3 pb-3 cursor-zoom-in" color="white" />
+      </div>
+    {/if}
+
+  </div>
   <div class="absolute bottom-0 left-0">
-    <ImageAttribution {image} />
+    <ImageAttribution {image} {attributionFormat} />
   </div>
 </div>

src/UI/Image/ImageAttribution.svelte

@@ -4,11 +4,15 @@
   import { Store, UIEventSource } from "../../Logic/UIEventSource"
   import ToSvelte from "../Base/ToSvelte.svelte"
   import { EyeIcon } from "@rgossiaux/svelte-heroicons/solid"
+  import Tr from "../Base/Tr.svelte"
+  import Translations from "../i18n/Translations"
 
   /**
    * A small element showing the attribution of a single image
    */
   export let image: Partial<ProvidedImage> & { id: string; url: string }
+  export let attributionFormat: "minimal" | "medium" | "large" = "medium"
+
   let license: Store<LicenseInfo> = UIEventSource.FromPromise(
     image.provider?.DownloadAttribution(image)
   )
@@ -16,14 +20,15 @@
 </script>
 
 {#if $license !== undefined}
-  <div class="no-images flex items-center rounded-lg bg-black p-0.5 pl-3 pr-3 text-sm text-white">
+  <div class="no-images flex items-center rounded-lg bg-black-transparent p-0.5 px-3 text-sm text-white">
     {#if icon !== undefined}
       <div class="mr-2 h-6 w-6">
         <ToSvelte construct={icon} />
       </div>
     {/if}
 
-    <div class="flex flex-col">
+    <div class="flex gap-x-2" class:flex-col={attributionFormat !== "minimal"}>
+      {#if attributionFormat !== "minimal" }
         {#if $license.title}
           {#if $license.informationLocation}
             <a href={$license.informationLocation.href} target="_blank" rel="noopener nofollower">
@@ -33,33 +38,41 @@
             $license.title
           {/if}
         {/if}
+      {/if}
 
       {#if $license.artist}
+        {#if attributionFormat === "large"}
+          <Tr t={Translations.t.general.attribution.madeBy.Subs({author: $license.artist})} />
+        {:else}
           <div class="font-bold">
             {@html $license.artist}
           </div>
         {/if}
-
-      <div class="flex w-full justify-between gap-x-1">
-        {#if $license.license !== undefined || $license.licenseShortName !== undefined}
-          <div>
-            {$license?.license ?? $license?.licenseShortName}
-          </div>
       {/if}
 
-        {#if $license.views}
-          <div class="flex justify-around self-center">
-            <EyeIcon class="h-4 w-4 pr-1" />
-            {$license.views}
-          </div>
-        {/if}
-      </div>
-
       {#if $license.date}
         <div>
           {$license.date.toLocaleDateString()}
         </div>
       {/if}
+
+      {#if attributionFormat !== "minimal"}
+        <div class="flex w-full justify-between gap-x-1">
+          {#if ($license.license !== undefined || $license.licenseShortName !== undefined)}
+            <div>
+              {$license?.license ?? $license?.licenseShortName}
+            </div>
+          {/if}
+
+          {#if $license.views}
+            <div class="flex justify-around self-center text-xs">
+              <EyeIcon class="h-4 w-4 pr-1" />
+              {$license.views}
+            </div>
+          {/if}
+        </div>
+      {/if}
+
     </div>
   </div>
 {/if}

src/UI/Image/ImageOperations.svelte

@@ -38,9 +38,9 @@
     class="pointer-events-none absolute bottom-0 left-0 flex w-full flex-wrap items-end justify-between"
   >
     <div
-      class="pointer-events-auto m-1 w-fit opacity-50 transition-colors duration-200 hover:opacity-100"
+      class="pointer-events-auto m-1 w-fit transition-colors duration-200"
     >
-      <ImageAttribution {image} />
+      <ImageAttribution {image} attributionFormat="large"/>
     </div>
 
     <button

src/UI/Image/LinkableImage.svelte

@@ -14,6 +14,8 @@
   import AttributedImage from "./AttributedImage.svelte"
   import SpecialTranslation from "../Popup/TagRendering/SpecialTranslation.svelte"
   import LoginToggle from "../Base/LoginToggle.svelte"
+  import ImagePreview from "./ImagePreview.svelte"
+  import FloatOver from "../Base/FloatOver.svelte"
 
   export let tags: UIEventSource<OsmTags>
   export let state: SpecialVisualizationState
@@ -31,7 +33,7 @@
     key: undefined,
     provider: AllImageProviders.byName(image.provider),
     date: new Date(image.date),
-    id: Object.values(image.osmTags)[0],
+    id: Object.values(image.osmTags)[0]
   }
 
   async function applyLink(isLinked: boolean) {
@@ -42,7 +44,7 @@
     if (isLinked) {
       const action = new LinkImageAction(currentTags.id, key, url, tags, {
         theme: tags.data._orig_theme ?? state.layout.id,
-        changeType: "link-image",
+        changeType: "link-image"
       })
       await state.changes.applyAction(action)
     } else {
@@ -51,24 +53,26 @@
         if (v === url) {
           const action = new ChangeTagAction(currentTags.id, new Tag(k, ""), currentTags, {
             theme: tags.data._orig_theme ?? state.layout.id,
-            changeType: "remove-image",
+            changeType: "remove-image"
           })
           state.changes.applyAction(action)
         }
       }
     }
   }
+
   isLinked.addCallback((isLinked) => applyLink(isLinked))
+
 </script>
 
-<div class="flex w-fit shrink-0 flex-col">
-  <div class="cursor-zoom-in" on:click={() => state.previewedImage.setData(providedImage)}>
+<div class="flex w-fit shrink-0 flex-col rounded-lg overflow-hidden" class:border-interactive={$isLinked}
+     style="border-width: 2px">
   <AttributedImage
     image={providedImage}
     imgClass="max-h-64 w-auto"
     previewedImage={state.previewedImage}
+    attributionFormat="minimal"
   />
-  </div>
   <LoginToggle {state} silentFail={true}>
     {#if linkable}
       <label>

src/UI/Image/NearbyImages.svelte

@@ -60,7 +60,7 @@
       <Tr t={Translations.t.image.nearby.noNearbyImages} cls="alert" />
     {/if}
   {:else}
-    <div class="flex w-full space-x-1 overflow-x-auto" style="scroll-snap-type: x proximity">
+    <div class="flex w-full space-x-4 overflow-x-auto" style="scroll-snap-type: x proximity">
       {#each $result as image (image.pictureUrl)}
         <span class="w-fit shrink-0" style="scroll-snap-align: start">
           <LinkableImage {tags} {image} {state} {feature} {layer} {linkable} />