midgard/mapcomplete
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Ignore wikidata claims without datavalue

Browse source
This commit is contained in:
pietervdvn 2021-10-06 19:19:35 +02:00
parent b5d2b99ced
commit 8d52ef1106
3 changed files with 1860 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Logic/Web/Wikidata.ts
View file

@ -47,8 +47,10 @@ export default class Wikidata {
const claimsList: any[] = entity.claims[claimId] const claimsList: any[] = entity.claims[claimId]
const values = new Set<string>() const values = new Set<string>()
for (const claim of claimsList) { for (const claim of claimsList) {
const value = claim.mainsnak.datavalue.value; const value = claim.mainsnak?.datavalueq?.value;
values.add(value) if(value !== undefined){
values.add(value)
}
} }
claims.set(claimId, values); claims.set(claimId, values);
} }

4
test/ImageProvider.spec.ts
View file

@ -57,6 +57,10 @@ export default class ImageProviderSpec extends T {
expects("https://commons.wikimedia.org/wiki/Special:FilePath/File%3ABrugge_Leeuwstraat_zonder_nummer_Leeuwbrug_-_119334_-_onroerenderfgoed.jpg?width=500&height=400",{ expects("https://commons.wikimedia.org/wiki/Special:FilePath/File%3ABrugge_Leeuwstraat_zonder_nummer_Leeuwbrug_-_119334_-_onroerenderfgoed.jpg?width=500&height=400",{
image:"File:Brugge_Leeuwstraat_zonder_nummer_Leeuwbrug_-_119334_-_onroerenderfgoed.jpg" image:"File:Brugge_Leeuwstraat_zonder_nummer_Leeuwbrug_-_119334_-_onroerenderfgoed.jpg"
}, "WikimediaImageProvider") }, "WikimediaImageProvider")
expects("https://commons.wikimedia.org/wiki/Special:FilePath/File%3APapageno_Jef_Claerhout.jpg?width=500&height=400",{
"wikimedia_commons": "File:Papageno_Jef_Claerhout.jpg"
}, "WikimediaImageProvider")
}] }]

1858
test/Wikidata.spec.test.ts
View file

File diff suppressed because it is too large Load diff