From e741ac5491c73c00aa1e48e7a96b97b3b37b4356 Mon Sep 17 00:00:00 2001 From: pietervdvn Date: Sun, 11 Apr 2021 02:46:47 +0200 Subject: [PATCH] Remove failed experiment to give feedback automatically --- .github/workflows/pull_request_check.yml | 18 ------------------ package.json | 4 ++-- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/.github/workflows/pull_request_check.yml b/.github/workflows/pull_request_check.yml index 01463c0..2638d54 100644 --- a/.github/workflows/pull_request_check.yml +++ b/.github/workflows/pull_request_check.yml @@ -32,21 +32,3 @@ jobs: - name: Validate license info run: npm run validate:licenses - - - name: Set failure key - run: | - if [[ -f "layer_report.txt" || -f "missing_licenses.txt" ]]; then - echo "VALIDATION_FAILED=true" >>$GITHUB_ENV - fi - - - name: Test variable - run: echo "${{ env.VALIDATION_FAILED }}" - - - name: Comment PR - uses: allthatjazzleo/actions-pull-request-add-comment@master - if: >- - env.VALIDATION_FAILED == 'true' - with: - # message: 'yoyo🤙🏻' - message: "cat layer_report.txt missing_licenses.txt" - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file diff --git a/package.json b/package.json index be63bb4..cc36ca8 100644 --- a/package.json +++ b/package.json @@ -17,8 +17,8 @@ "generate:docs": "ts-node scripts/generateDocs.ts", "generate:layeroverview": "ts-node scripts/generateLayerOverview.ts --no-fail", "generate:licenses": "ts-node scripts/generateLicenseInfo.ts --no-fail", - "validate:layeroverview": "ts-node scripts/generateLayerOverview.ts --report --no-fail", - "validate:licenses": "ts-node scripts/generateLicenseInfo.ts --report --no-fail", + "validate:layeroverview": "ts-node scripts/generateLayerOverview.ts --report", + "validate:licenses": "ts-node scripts/generateLicenseInfo.ts --report", "optimize-images": "cd assets/generated/ && find -name '*.png' -exec optipng '{}' \\; && echo 'PNGs are optimized'", "generate": "npm run generate:images && npm run generate:translations && npm run generate:licenses", "build": "rm -rf dist/ && npm run generate && parcel build --public-url ./ *.html assets/** assets/**/** assets/**/**/** vendor/* vendor/*/*",