From e81ea3db0b5a6de27cf9cd2d91b3c36e98109293 Mon Sep 17 00:00:00 2001
From: Pieter Vander Vennet <pietervdvn@posteo.net>
Date: Mon, 14 Nov 2022 02:03:23 +0100
Subject: [PATCH] Add check as to always have a source or an author

---
 assets/svg/teardrop_with_hole_green.svg | 57 -------------------------
 assets/themes/width/license_info.json   |  4 +-
 scripts/generateLicenseInfo.ts          | 13 +++++-
 3 files changed, 14 insertions(+), 60 deletions(-)
 delete mode 100644 assets/svg/teardrop_with_hole_green.svg

diff --git a/assets/svg/teardrop_with_hole_green.svg b/assets/svg/teardrop_with_hole_green.svg
deleted file mode 100644
index 947562fc3..000000000
--- a/assets/svg/teardrop_with_hole_green.svg
+++ /dev/null
@@ -1,57 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<svg
-   width="400"
-   height="400"
-   viewBox="0 0 400 400"
-   version="1.1"
-   id="svg11"
-   sodipodi:docname="teardrop_with_hole_green.svg"
-   inkscape:version="1.1.1 (1:1.1+202109281949+c3084ef5ed)"
-   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
-   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
-   xmlns="http://www.w3.org/2000/svg"
-   xmlns:svg="http://www.w3.org/2000/svg">
-  <defs
-     id="defs15" />
-  <sodipodi:namedview
-     id="namedview13"
-     pagecolor="#505050"
-     bordercolor="#eeeeee"
-     borderopacity="1"
-     inkscape:pageshadow="0"
-     inkscape:pageopacity="0"
-     inkscape:pagecheckerboard="0"
-     showgrid="false"
-     width="400px"
-     showguides="true"
-     inkscape:guide-bbox="true"
-     inkscape:zoom="1.8002433"
-     inkscape:cx="161.08934"
-     inkscape:cy="210.5271"
-     inkscape:current-layer="svg11">
-    <sodipodi:guide
-       position="199.99891,418.65297"
-       orientation="1,0"
-       id="guide832" />
-  </sodipodi:namedview>
-  <g
-     id="surface1"
-     transform="matrix(1.0785793,0,0,1.0785793,51.765885,-0.40531133)">
-    <path
-       style="fill:#007f00;fill-opacity:0.988235;fill-rule:nonzero;stroke:none"
-       d="m 137.43359,370.03516 c -0.82812,-2.00782 -18.03125,-18.8086 -30.35156,-34.07422 C 34.097656,239.17969 -47.273438,149.25781 47.746094,39.980469 89.816406,-0.617188 141.69141,-2.933594 195.02344,15.992188 345.19141,102.77734 236.46875,244.35156 165.07812,337.42187 Z M 182.60547,221.6875 C 282.76562,150.14844 205.32812,12.386719 95.28125,58.183594 63.148438,75.296875 47.203125,105.07031 46.644531,140.19531 c -1.535156,34.16406 16.632813,62.73438 45.421875,80.23438 20.640624,11.22265 29.714844,13.24609 53.085934,11.85547 15.14844,-0.89844 23.875,-3.3711 37.45313,-10.59766 z m 0,0"
-       id="path2" />
-    <path
-       style="fill:#007f00;fill-opacity:0.988235;fill-rule:nonzero;stroke:none"
-       d="M 108.72266,255.84375 C 37.953125,241.13281 -7.363281,173.46875 7.277344,104.37109 21.914062,35.273438 91.019531,-9.34375 161.97656,4.492188 232.9375,18.328125 279.12891,85.421875 265.39062,154.69922 251.65625,223.97266 183.13672,269.4375 112.00391,256.48437"
-       id="path4" />
-    <path
-       style="fill:#009400;fill-opacity:1;fill-rule:nonzero;stroke:none"
-       d="M 117.33203,237.78516 C 64.75,226.24609 31.078125,173.16797 41.957031,118.96875 52.835938,64.765625 104.17969,29.769531 156.89844,40.621094 c 52.72265,10.851562 87.04297,63.484376 76.83593,117.824216 -10.20703,54.33985 -61.11328,90.00391 -113.96484,79.84375"
-       id="path6" />
-    <path
-       style="fill:#ffffff;fill-opacity:1;fill-rule:nonzero;stroke:none"
-       d="M 122.92188,202.85156 C 88.144531,195.28125 65.878906,160.48437 73.074219,124.94531 80.265625,89.40625 114.22266,66.457031 149.08594,73.574219 c 34.86718,7.117187 57.5664,41.625001 50.8164,77.253901 -6.75,35.62891 -40.41797,59.01563 -75.37109,52.35157"
-       id="path8" />
-  </g>
-</svg>
diff --git a/assets/themes/width/license_info.json b/assets/themes/width/license_info.json
index 20cd90555..2e786730b 100644
--- a/assets/themes/width/license_info.json
+++ b/assets/themes/width/license_info.json
@@ -2,7 +2,7 @@
   {
     "path": "icon.svg",
     "license": "CC0; trivial",
-    "authors": [],
+    "authors": ["Pieter Vander Vennet"],
     "sources": []
   }
-]
\ No newline at end of file
+]
diff --git a/scripts/generateLicenseInfo.ts b/scripts/generateLicenseInfo.ts
index 3a8b7567b..5fbf819e7 100644
--- a/scripts/generateLicenseInfo.ts
+++ b/scripts/generateLicenseInfo.ts
@@ -279,7 +279,18 @@ function main(args: string[]) {
     const invalidLicenses = licenseInfos
         .filter((l) => (l.license ?? "") === "")
         .map((l) => `License for artwork ${l.path} is empty string or undefined`)
+
+    let invalid = 0
     for (const licenseInfo of licenseInfos) {
+
+        if(licenseInfo.sources.length + licenseInfo.authors.length == 0){
+            invalid++
+            invalidLicenses.push(
+                "Invalid license: No sources nor authors given in the license for " + JSON.stringify(licenseInfo)
+            )
+            continue
+        }
+
         for (const source of licenseInfo.sources) {
             if (source == "") {
                 invalidLicenses.push(
@@ -294,7 +305,7 @@ function main(args: string[]) {
         }
     }
 
-    if (missingLicenses.length > 0) {
+    if (missingLicenses.length > 0 || invalidLicenses.length) {
         const msg = `There are ${missingLicenses.length} licenses missing and ${invalidLicenses.length} invalid licenses.`
         console.log(missingLicenses.concat(invalidLicenses).join("\n"))
         console.error(msg)