From 0249a58a364a386390ad741338993901891b2d25 Mon Sep 17 00:00:00 2001
From: Midgard <midgard@zeus.ugent.be>
Date: Fri, 27 Oct 2023 13:59:15 +0200
Subject: [PATCH] Fix error path when channel is not found

---
 mmcli/mmcli.py | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/mmcli/mmcli.py b/mmcli/mmcli.py
index db04de1..46f873b 100755
--- a/mmcli/mmcli.py
+++ b/mmcli/mmcli.py
@@ -128,17 +128,23 @@ def predicate_for_query(query: str):
 
 
 def resolve_team(mm_api: mattermost.MMApi, query: str) -> Optional[Dict]:
-	return first(filter(
-		predicate_for_query(query),
-		mm_api.get_teams()
-	))
+	return first(
+		filter(
+			predicate_for_query(query),
+			mm_api.get_teams()
+		),
+		None
+	)
 
 
 def resolve_channel(mm_api: mattermost.MMApi, team_id: str, query: str) -> Optional[Dict]:
-	return first(filter(
-		predicate_for_query(query),
-		mm_api.get_team_channels(team_id)
-	))
+	return first(
+		filter(
+			predicate_for_query(query),
+			mm_api.get_team_channels(team_id)
+		),
+		None
+	)
 
 
 def resolve_team_channel(mm_api: mattermost.MMApi, query: str) -> Dict:
@@ -156,7 +162,7 @@ def resolve_team_channel(mm_api: mattermost.MMApi, query: str) -> Dict:
 	else:
 		channel = resolve_channel(mm_api, team["id"], query_parts[1])
 	if not channel:
-		return NotFound("channel", query_parts[1])
+		raise NotFound("channel", query_parts[1])
 
 	return team, channel