Simplify ability

app/models/ability.rb

@@ -4,24 +4,32 @@ class Ability
   def initialize(user)
     return unless user
 
-    can :read, Barcode
+    initialize_admin if user.admin?
+    initialize_koelkast if user.koelkast?
+    initialize_user
 
-    if user.admin?
+    can :read, Barcode
-      can :manage, :all
+  end
-    elsif user.koelkast?
+
-      can :manage, Order do |order|
+  def initialize_admin
-        !order.try(:user).try(:private)
+    can :manage, :all
-      end
+  end
-      can :quickpay, User
+
-    else
+  def initialize_koelkast
-      can :read, :all
+    can :manage, Order do |order|
-      can :manage, User, id: user.id
+      !order.try(:user).try(:private)
-      can :create, Order do |order|
+    end
-        order.try(:user) == user
+    can :quickpay, User
-      end
+  end
-      can :destroy, Order do |order|
+
-        order.try(:user) == user && order.deletable
+  def initialize_user
-      end
+    can :read, :all
+    can :manage, User, id: user.id
+    can :create, Order do |order|
+      order.try(:user) == user
+    end
+    can :destroy, Order do |order|
+      order.try(:user) == user && order.deletable
     end
   end
 end