From 73c536b4a6d8cbc788ca4a22ed1c62744f3fa12f Mon Sep 17 00:00:00 2001
From: Ilion Beyst <ilion.beyst@gmail.com>
Date: Wed, 20 Jul 2022 23:21:06 +0200
Subject: [PATCH] wrap bot api in oneof for extendability

---
 planetwars-server/src/modules/bot_api.rs | 42 +++++++++++++++---------
 proto/bot_api.proto                      | 19 ++++++-----
 2 files changed, 38 insertions(+), 23 deletions(-)

diff --git a/planetwars-server/src/modules/bot_api.rs b/planetwars-server/src/modules/bot_api.rs
index 33f5d87..cb12275 100644
--- a/planetwars-server/src/modules/bot_api.rs
+++ b/planetwars-server/src/modules/bot_api.rs
@@ -66,12 +66,12 @@ impl PlayerRouter {
 
 #[tonic::async_trait]
 impl pb::bot_api_service_server::BotApiService for BotApiServer {
-    type ConnectBotStream = UnboundedReceiverStream<Result<pb::PlayerRequest, Status>>;
+    type ConnectPlayerStream = UnboundedReceiverStream<Result<pb::ServerMessage, Status>>;
 
-    async fn connect_bot(
+    async fn connect_player(
         &self,
-        req: Request<Streaming<pb::PlayerRequestResponse>>,
-    ) -> Result<Response<Self::ConnectBotStream>, Status> {
+        req: Request<Streaming<pb::ClientMessage>>,
+    ) -> Result<Response<Self::ConnectPlayerStream>, Status> {
         // TODO: clean up errors
         let player_key = req
             .metadata()
@@ -141,8 +141,8 @@ impl pb::bot_api_service_server::BotApiService for BotApiServer {
 
 // TODO: please rename me
 struct SyncThingData {
-    tx: oneshot::Sender<Streaming<pb::PlayerRequestResponse>>,
-    server_messages: mpsc::UnboundedReceiver<Result<pb::PlayerRequest, Status>>,
+    tx: oneshot::Sender<Streaming<pb::ClientMessage>>,
+    server_messages: mpsc::UnboundedReceiver<Result<pb::ServerMessage, Status>>,
 }
 
 struct RemoteBotSpec {
@@ -199,29 +199,41 @@ impl runner::BotSpec for RemoteBotSpec {
 async fn handle_bot_messages(
     player_id: u32,
     event_bus: Arc<Mutex<EventBus>>,
-    mut messages: Streaming<pb::PlayerRequestResponse>,
+    mut messages: Streaming<pb::ClientMessage>,
 ) {
+    // TODO: can this be writte nmore nicely?
     while let Some(message) = messages.message().await.unwrap() {
-        let request_id = (player_id, message.request_id as u32);
-        event_bus
-            .lock()
-            .unwrap()
-            .resolve_request(request_id, Ok(message.content));
+        match message.client_message {
+            Some(pb::client_message::ClientMessage::RequestResponse(resp)) => {
+                let request_id = (player_id, resp.request_id as u32);
+                event_bus
+                    .lock()
+                    .unwrap()
+                    .resolve_request(request_id, Ok(resp.content));
+            }
+            _ => (),
+        }
     }
 }
 
 struct RemoteBotHandle {
-    sender: mpsc::UnboundedSender<Result<pb::PlayerRequest, Status>>,
+    sender: mpsc::UnboundedSender<Result<pb::ServerMessage, Status>>,
     player_id: u32,
     event_bus: Arc<Mutex<EventBus>>,
 }
 
 impl PlayerHandle for RemoteBotHandle {
     fn send_request(&mut self, r: RequestMessage) {
-        let res = self.sender.send(Ok(pb::PlayerRequest {
+        let req = pb::PlayerRequest {
             request_id: r.request_id as i32,
             content: r.content,
-        }));
+        };
+
+        let server_message = pb::ServerMessage {
+            server_message: Some(pb::server_message::ServerMessage::PlayerRequest(req)),
+        };
+
+        let res = self.sender.send(Ok(server_message));
         match res {
             Ok(()) => {
                 // schedule a timeout. See comments at method implementation
diff --git a/proto/bot_api.proto b/proto/bot_api.proto
index 08839f0..4b07c7c 100644
--- a/proto/bot_api.proto
+++ b/proto/bot_api.proto
@@ -2,19 +2,22 @@ syntax = "proto3";
 
 package grpc.planetwars.bot_api;
 
-message Hello {
-  string hello_message = 1;
+message ServerMessage {
+  oneof server_message {
+    PlayerRequest player_request = 1;
+  }
 }
-
-message HelloResponse {
-  string response = 1;
-}
-
 message PlayerRequest {
   int32 request_id = 1;
   bytes content = 2;
 }
 
+message ClientMessage {
+  oneof client_message {
+    PlayerRequestResponse request_response = 1;
+  }
+}
+
 message PlayerRequestResponse {
   int32 request_id = 1;
   bytes content = 2;
@@ -32,5 +35,5 @@ message CreatedMatch {
 service BotApiService {
   rpc CreateMatch(MatchRequest) returns (CreatedMatch);
   // server sends requests to the player, player responds
-  rpc ConnectBot(stream PlayerRequestResponse) returns (stream PlayerRequest);
+  rpc ConnectPlayer(stream ClientMessage) returns (stream ServerMessage);
 }