xerbalind/planetwars.dev
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages 1 Wiki Activity

registry: ensure that files have been closed before calculating checksums

Browse source
This commit is contained in:
Ilion Beyst 2022-08-30 19:35:29 +02:00
parent e8e353192c
commit d95eedcc83
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
planetwars-server/src/modules/registry.rs
View file

@ -300,8 +300,10 @@ async fn put_upload(
while let Some(Ok(chunk)) = stream.next().await { while let Some(Ok(chunk)) = stream.next().await {
file.write_all(&chunk).await.unwrap(); file.write_all(&chunk).await.unwrap();
} }
file.flush().await.unwrap();
let range_end = last_byte_pos(&file).await.unwrap(); let range_end = last_byte_pos(&file).await.unwrap();
// Close the file to ensure all data has been flushed to the kernel.
// If we don't do this, calculating the checksum can fail.
std::mem::drop(file);
let expected_digest = params.digest.strip_prefix("sha256:").unwrap(); let expected_digest = params.digest.strip_prefix("sha256:").unwrap();
let digest = file_sha256_digest(&upload_path).unwrap(); let digest = file_sha256_digest(&upload_path).unwrap();