ZeusWPI/kers
9
0
Fork 0
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity

Remove hardcoded "A" and "I" #7

Closed
midgard wants to merge 4 commits from no-hardcoding into master
pull from: no-hardcoding
merge into: ZeusWPI:master
Conversation 6 Commits 4 Files changed 3 +37 -29
midgard commented 2020-07-25 18:42:22 +02:00 (Migrated from git.zeus.gent)
Copy link

These stand for "admitted" and "interested", but we have constants for
that.

Also: fix a typo, remove cargo culted .all(), use saner indentation.

These stand for "admitted" and "interested", but we have constants for that. Also: fix a typo, remove cargo culted `.all()`, use saner indentation.
midgard commented 2020-07-25 21:24:10 +02:00 (Migrated from git.zeus.gent)
Copy link

added 1 commit

  • c2535659 - Fix multiple problems in event place assignment

Compare with previous version

added 1 commit <ul><li>c2535659 - Fix multiple problems in event place assignment</li></ul> [Compare with previous version](/bestuur/kers/merge_requests/2/diffs?diff_id=248&start_sha=7e9b23d4a12dd88ddafdf815caf067cd5ba1693c)
midgard commented 2020-07-25 21:25:51 +02:00 (Migrated from git.zeus.gent)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a37e59ed - Remove /test endpoint</li></ul> [Compare with previous version](/bestuur/kers/merge_requests/2/diffs?diff_id=249&start_sha=c25356594a3709056849babeae7b48e8c67822af)
midgard commented 2020-07-25 21:27:19 +02:00 (Migrated from git.zeus.gent)
Copy link

added 1 commit

  • bd714538 - Convert back to print since not needed on web any more

Compare with previous version

added 1 commit <ul><li>bd714538 - Convert back to print since not needed on web any more</li></ul> [Compare with previous version](/bestuur/kers/merge_requests/2/diffs?diff_id=250&start_sha=a37e59ed024f1c3d3a6b62bcbbcda2c5da51c0ef)
flynn commented 2020-07-25 21:33:03 +02:00 (Migrated from git.zeus.gent)
Copy link

Dit maakt de assumptie dat een gebruiker maar 1 registratie op een event kan hebben. Hier zou dan best ook constraint voor komen in de database of de dubbelen moeten eruit gehaald worden zoals voorheen.

Dit maakt de assumptie dat een gebruiker maar 1 registratie op een event kan hebben. Hier zou dan best ook constraint voor komen in de database of de dubbelen moeten eruit gehaald worden zoals voorheen.
flynn commented 2020-07-25 21:34:48 +02:00 (Migrated from git.zeus.gent)
Copy link

Hier overschrijf je de vorige registrations variabele welke de verzameling was van die van de hele dag. Hier is het van 1 event.
In de volgende loop ga je dus niet de juiste registraties hebben.

Hier overschrijf je de vorige `registrations` variabele welke de verzameling was van die van de hele dag. Hier is het van 1 event. In de volgende loop ga je dus niet de juiste registraties hebben.
midgard commented 2020-07-26 00:26:34 +02:00 (Migrated from git.zeus.gent)
Copy link

closed

closed

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ZeusWPI/kers#7
No description provided.
Delete branch "no-hardcoding"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?